fix: add .js extension to react-reconciler/constants imports for Node.js ESM #511
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….js ESM Node.js ESM requires explicit file extensions for subpath imports. Without the .js extension, Node.js throws: Error: Cannot find module 'react-reconciler/constants' Did you mean to import "react-reconciler/constants.js"? This affects projects using @opentui/react with Node.js test runners like Vitest that run in ESM mode. Co-Authored-By: Claude Opus 4.5 <[email protected]>
nathanclevenger
requested review from
Adictya,
Hona,
fezproof,
kommander and
msmps
as code owners
Collaborator
|
@msmps you can probably better judge the impact. |
@opentui/core
@opentui/react
@opentui/solid
@opentui/core-darwin-arm64
@opentui/core-darwin-x64
@opentui/core-linux-arm64
@opentui/core-linux-x64
@opentui/core-win32-arm64
@opentui/core-win32-x64
commit: |
Collaborator
|
I just realized "which works in Bun but fails in Node.js", but there is no way currently to use opentui with nodejs as it is bun FFI only. So I don't see what this would solve? |
Contributor
|
Yeah the user probably tried running it in Node.js and this was the first visible issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Node.js ESM mode requires explicit file extensions for subpath imports from packages. The current code imports from
react-reconciler/constantswithout the.jsextension, which works in Bun but fails in Node.js:This breaks projects using
@opentui/reactwith Node.js-based test runners like Vitest running in ESM mode.Solution
Add the
.jsextension to the tworeact-reconciler/constantsimports:packages/react/src/reconciler/host-config.tspackages/react/src/reconciler/reconciler.tsThis is backward compatible - the
.jsextension works correctly in both Bun and Node.js.Testing
Tested with Vitest in a pnpm monorepo - the import errors are resolved.